From 22e30f300d1619769dde4ce70c8b288e6aad9af4 Mon Sep 17 00:00:00 2001 From: Michael Gecht Date: Tue, 21 May 2019 08:50:57 +0200 Subject: [PATCH] Wrap selector logic in try..except statement This catches all errors that are thrown, when any `find_element_by_*` method fails for some reason. If this happens, we just fall through and wait for a page refresh and then try again. --- deletefb/deletefb.py | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/deletefb/deletefb.py b/deletefb/deletefb.py index 231adf6..30e8f52 100755 --- a/deletefb/deletefb.py +++ b/deletefb/deletefb.py @@ -103,27 +103,30 @@ def delete_posts(user_email_address, driver.get(user_profile_url) for _ in range(MAX_POSTS): - post_button_sel = "_4xev" - timeline_element = driver.find_element_by_class_name(post_button_sel) - actions = ActionChains(driver) - actions.move_to_element(timeline_element).click().perform() + try: + post_button_sel = "_4xev" + timeline_element = driver.find_element_by_class_name(post_button_sel) + actions = ActionChains(driver) + actions.move_to_element(timeline_element).click().perform() - menu = driver.find_element_by_css_selector("#globalContainer > div.uiContextualLayerPositioner.uiLayer > div") - actions.move_to_element(menu).perform() + menu = driver.find_element_by_css_selector("#globalContainer > div.uiContextualLayerPositioner.uiLayer > div") + actions.move_to_element(menu).perform() - try: - delete_button = menu.find_element_by_xpath("//a[@data-feed-option-name=\"FeedDeleteOption\"]") + try: + delete_button = menu.find_element_by_xpath("//a[@data-feed-option-name=\"FeedDeleteOption\"]") - # FIXME Using a bare except here to avoid having to handle all possible exceptions - except: - delete_button = menu.find_element_by_xpath("//a[@data-feed-option-name=\"HIDE_FROM_TIMELINE\"]") + # FIXME Using a bare except here to avoid having to handle all possible exceptions + except: + delete_button = menu.find_element_by_xpath("//a[@data-feed-option-name=\"HIDE_FROM_TIMELINE\"]") - actions.move_to_element(delete_button).click().perform() + actions.move_to_element(delete_button).click().perform() - confirmation_button = driver.find_element_by_class_name("layerConfirm") + confirmation_button = driver.find_element_by_class_name("layerConfirm") - # Facebook would not let me get focus on this button without some custom JS - driver.execute_script("arguments[0].click();", confirmation_button) + # Facebook would not let me get focus on this button without some custom JS + driver.execute_script("arguments[0].click();", confirmation_button) + except: + pass # Required to sleep the thread for a bit after using JS to click this button time.sleep(5)