From abe597db9b87f66e8d5a1ea49d611b298d3a721e Mon Sep 17 00:00:00 2001 From: Wesley Kerfoot Date: Sat, 18 Jan 2020 13:58:38 -0500 Subject: [PATCH 1/3] Refactor variable names --- deletefb/tools/login.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/deletefb/tools/login.py b/deletefb/tools/login.py index c1c67a5..63d0156 100644 --- a/deletefb/tools/login.py +++ b/deletefb/tools/login.py @@ -52,14 +52,9 @@ def login(user_email_address, login_button = "loginbutton" approvals_code = "approvals_code" - emailelement = driver.find_element_by_name(email) - passwordelement = driver.find_element_by_name(password) - - emailelement.send_keys(user_email_address) - passwordelement.send_keys(user_password) - - loginelement = driver.find_element_by_id(login_button) - loginelement.click() + driver.find_element_by_name(email).send_keys(user_email_address) + driver.find_element_by_name(password).send_keys(user_password) + driver.find_element_by_id(login_button).click() # Defaults to no 2fa has_2fa = False From 0e24537f42b703bc8782951c1de86a348ffc4f98 Mon Sep 17 00:00:00 2001 From: Wesley Kerfoot Date: Sat, 18 Jan 2020 14:04:41 -0500 Subject: [PATCH 2/3] More refactoring --- deletefb/tools/chrome_driver.py | 42 +++++++++++++-------------------- 1 file changed, 16 insertions(+), 26 deletions(-) diff --git a/deletefb/tools/chrome_driver.py b/deletefb/tools/chrome_driver.py index 2069340..a0247d8 100644 --- a/deletefb/tools/chrome_driver.py +++ b/deletefb/tools/chrome_driver.py @@ -1,25 +1,21 @@ -import re -import zipfile -import os, sys, stat, platform -from urllib.request import urlretrieve -from collections import namedtuple - +from ..exceptions import UnknownOSException +from .common import NO_CHROME_DRIVER from clint.textui import puts, colored -import progressbar - +from collections import namedtuple from selenium import webdriver +from urllib.request import urlretrieve +from enum import Enum -from .common import NO_CHROME_DRIVER -from ..exceptions import UnknownOSException - - -_ = namedtuple('WebDrivers', 'mac linux windows') -drivers = ['https://chromedriver.storage.googleapis.com/78.0.3904.70/chromedriver_mac64.zip', - 'https://chromedriver.storage.googleapis.com/78.0.3904.70/chromedriver_linux64.zip', - 'https://chromedriver.storage.googleapis.com/78.0.3904.70/chromedriver_win32.zip' - ] -WebDriver = _(drivers[0], drivers[1], drivers[2]) +import os, sys, stat, platform +import progressbar +import re +import zipfile +chrome_drivers = { + "Windows" : "https://chromedriver.storage.googleapis.com/78.0.3904.70/chromedriver_win32.zip", + "Darwin" : "https://chromedriver.storage.googleapis.com/78.0.3904.70/chromedriver_mac64.zip", + "Linux" : "https://chromedriver.storage.googleapis.com/78.0.3904.70/chromedriver_linux64.zip" +} def extract_zip(filename): """ @@ -71,14 +67,8 @@ def get_webdriver(): else: # Download it according to the current machine - os_platform = platform.system() - if os_platform == 'Darwin': - chrome_webdriver = WebDriver.mac - elif os_platform == 'Linux': - chrome_webdriver = WebDriver.linux - elif os_platform == 'Windows': - chrome_webdriver = WebDriver.windows - else: + chrome_webdriver = chrome_drivers.get(platform.system(), False) + if not chrome_webdriver: raise UnknownOSException("Unknown Operating system platform") global total_size From bc210890e5edbf534c2f2d600e212d0cb31a0167 Mon Sep 17 00:00:00 2001 From: Wesley Kerfoot Date: Sat, 18 Jan 2020 14:05:54 -0500 Subject: [PATCH 3/3] Refactor imports --- deletefb/tools/chrome_driver.py | 2 -- deletefb/tools/login.py | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/deletefb/tools/chrome_driver.py b/deletefb/tools/chrome_driver.py index a0247d8..c59361e 100644 --- a/deletefb/tools/chrome_driver.py +++ b/deletefb/tools/chrome_driver.py @@ -1,10 +1,8 @@ from ..exceptions import UnknownOSException from .common import NO_CHROME_DRIVER from clint.textui import puts, colored -from collections import namedtuple from selenium import webdriver from urllib.request import urlretrieve -from enum import Enum import os, sys, stat, platform import progressbar diff --git a/deletefb/tools/login.py b/deletefb/tools/login.py index 63d0156..daae1d5 100644 --- a/deletefb/tools/login.py +++ b/deletefb/tools/login.py @@ -1,10 +1,9 @@ +from .chrome_driver import get_webdriver, setup_selenium from selenium.common.exceptions import NoSuchElementException from selenium.webdriver.chrome.options import Options import time -from .chrome_driver import get_webdriver, setup_selenium - def login(user_email_address, user_password, is_headless,