wes
/
DeleteFB
1
0
Fork 0
Code Issues 26 Pull Requests 3 Projects Releases 12 Wiki Activity
Labels Milestones

Starting a refactor of all chrome driver code #105

Merged
weskerfoot merged 4 commits from chrome-driver-refactor into master 5 years ago
Conversation 2 Commits 4 Files Changed 3
weskerfoot commented 5 years ago (Migrated from github.com)
Owner

The chrome driver related code has several issues:

  • It does not allow a user to specify the exact version
  • It is not really robust against future updates
  • It could probably be simplified and cleaned up more

The solution here is to calculate the exact version based on the version of the Chrome browser installed. This is easy on Linux or MacOS, but a bit tricky on windows.

This will address https://github.com/weskerfoot/DeleteFB/issues/94

The chrome driver related code has several issues: - It does not allow a user to specify the exact version - It is not really robust against future updates - It could probably be simplified and cleaned up more The solution here is to calculate the exact version based on the version of the Chrome browser installed. This is easy on Linux or MacOS, but a bit tricky on windows. This will address https://github.com/weskerfoot/DeleteFB/issues/94
whuji commented 5 years ago (Migrated from github.com)
Owner

Hello,

https://github.com/weskerfoot/DeleteFB/pull/114

I did a PR with a refactor of the chromedriver download also, where I always pick the latest version. Is there any retro-compatibility issue you are aware of with the chromedriver ? (I have a Chrome 80.XXX and a Chromdriver 80.YYY with XXX < YYY and it works).

Hello, https://github.com/weskerfoot/DeleteFB/pull/114 I did a PR with a refactor of the chromedriver download also, where I always pick the latest version. Is there any retro-compatibility issue you are aware of with the chromedriver ? (I have a Chrome 80.XXX and a Chromdriver 80.YYY with XXX < YYY and it works).
weskerfoot commented 5 years ago (Migrated from github.com)
Poster
Owner

Picking this back up again

Picking this back up again
The pull request has been merged as 82d749f261.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something isn't working dependencies
Pull requests that update a dependency file discussion documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested wontfix
This will not be worked on
No Label bug dependencies discussion documentation duplicate enhancement good first issue help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'chrome-driver-refactor'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes