wes
/
DeleteFB
1
0
Fork 0
Code Issues 26 Pull Requests 3 Projects Releases 12 Wiki Activity
Labels Milestones
New Issue

update chromedriver to 80 #110

Closed
by sharath-psh opened 4 years ago · 4 comments
sharath-psh commented 4 years ago (Migrated from github.com)
Owner

current script automatically downloads chromedriver 78 but the current latest stable version of chrome which everyone uses is chrome 80 , please update the chromedriver to support chrome 80.

current script automatically downloads chromedriver 78 but the current latest stable version of chrome which everyone uses is chrome 80 , please update the chromedriver to support chrome 80.
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

It's in progress to get rid of the hardcoded version number :) I had some issues testing on windows but it should be sorted out soon https://github.com/weskerfoot/DeleteFB/pull/105

It's in progress to get rid of the hardcoded version number :) I had some issues testing on windows but it should be sorted out soon https://github.com/weskerfoot/DeleteFB/pull/105
👍 1
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

I can update the version that's hardcoded for now I suppose

I can update the version that's hardcoded for now I suppose
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

Updated the major version to 80. That should solve it for now. I hope to get the branch that auto-detects the version merged at some point in order to solve this issue.

Updated the major version to 80. That should solve it for now. I hope to get the branch that auto-detects the version merged at some point in order to solve this issue.
🎉 1
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

This will now dynamically generate the correct chromedriver version based on your google chrome / chromium version so it should not be an issue again

This will now dynamically generate the correct chromedriver version based on your google chrome / chromium version so it should not be an issue again
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
bugfixes
cattrs-fix
chrome-driver-refactor
comments
dependabot/pip/lxml-4.6.5
dependabot/pip/urllib3-1.26.5
fix-unlikes
fix-untag
fix-year
headless-fix
master
Labels
Apply labels
Clear labels
bug
Something isn't working dependencies
Pull requests that update a dependency file discussion documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested wontfix
This will not be worked on
No Label bug dependencies discussion documentation duplicate enhancement good first issue help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes