wes
/
DeleteFB
1
0
Fork 0
Code Issues 26 Pull Requests 3 Projects Releases 12 Wiki Activity
Labels Milestones
New Issue

Prefer chromedriver in $PATH #119

Closed
by JeffCarpenter opened 4 years ago · 3 comments
JeffCarpenter commented 4 years ago (Migrated from github.com)
Owner

Hi there,

I have chromedriver and Chromium 80 installed on my machine, but when I ran deletefb, it downloaded an older copy of chromedriver and exited with an error that it only supports Chrome 78.

Thanks for the handy script, and if you'd like a PR I'd be happy to send one your way.

Hi there, I have chromedriver and Chromium 80 installed on my machine, but when I ran deletefb, it downloaded an older copy of chromedriver and exited with an error that it only supports Chrome 78. Thanks for the handy script, and if you'd like a PR I'd be happy to send one your way.
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

Hey, this should be fixed (regarding the out of date chromedriver) in the latest commit, but I haven't done a release yet. I'll try to do one today.

For preferring the version in the $PATH, yes please go ahead and submit a PR!

Hey, this should be fixed (regarding the out of date chromedriver) in the latest commit, but I haven't done a release yet. I'll try to do one today. For preferring the version in the `$PATH`, yes please go ahead and submit a PR!
👍 1
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

I just merged some changes that should improve this logic even more and keep versioned chromedriver binaries in your user cache directory. Please let me know if version 1.1.13 (just released to PyPI) solves your problem, thanks!

I just merged some changes that should improve this logic even more and keep versioned chromedriver binaries in your user cache directory. Please let me know if version `1.1.13` (just released to PyPI) solves your problem, thanks!
JeffCarpenter commented 4 years ago (Migrated from github.com)
Poster
Owner

Yep, it goes right ahead and downloads chromedriver 80. Thanks

Yep, it goes right ahead and downloads chromedriver 80. Thanks
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
bugfixes
cattrs-fix
chrome-driver-refactor
comments
dependabot/pip/lxml-4.6.5
dependabot/pip/urllib3-1.26.5
fix-unlikes
fix-untag
fix-year
headless-fix
master
Labels
Apply labels
Clear labels
bug
Something isn't working dependencies
Pull requests that update a dependency file discussion documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested wontfix
This will not be worked on
No Label bug dependencies discussion documentation duplicate enhancement good first issue help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes