Refactor #48

Merged
connorskees merged 1 commits from master into master 5 years ago
connorskees commented 5 years ago (Migrated from github.com)
Owner

This pull request

  • Reorders imports
  • Adds Google style docstrings to functions
  • Reformats nested whitespace
  • Renames global constants to be in UPPER_CASE
This pull request - Reorders imports - Adds Google style docstrings to functions - Reformats nested whitespace - Renames global constants to be in UPPER_CASE
weskerfoot commented 5 years ago (Migrated from github.com)
Owner

Looks good. Thanks for the help! I'm going to try and knock off a few of the bugs that require more in-depth testing soon so I think I'll just merge this in right away if that's ok.

Looks good. Thanks for the help! I'm going to try and knock off a few of the bugs that require more in-depth testing soon so I think I'll just merge this in right away if that's ok.
weskerfoot commented 5 years ago (Migrated from github.com)
Owner

Also the whole archiving interface is still kind of a proof of concept, and I'm not sure if I'll stick with it or not. The reason I did it that way (enabling line buffering and explicitly closing the log file) is just for flexibility, but there might be a better way of handling it if it gets to be too clumsy.

Also the whole archiving interface is still kind of a proof of concept, and I'm not sure if I'll stick with it or not. The reason I did it that way (enabling line buffering and explicitly closing the log file) is just for flexibility, but there might be a better way of handling it if it gets to be too clumsy.
The pull request has been merged as 3e6e90cf87.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.