Refactor wall module & refactor archiver #53

Merged
weskerfoot merged 11 commits from refactor into master 5 years ago
weskerfoot commented 5 years ago (Migrated from github.com)
Owner

Trying to refactor things to make it a bit more extensible and detect when it's completed processing.

Part of this is based on feedback from here https://www.pyracode.net/articles/12

Trying to refactor things to make it a bit more extensible and detect when it's completed processing. Part of this is based on feedback from here https://www.pyracode.net/articles/12
weskerfoot commented 5 years ago (Migrated from github.com)
Poster
Owner

Hoping to get this in tomorrow

Hoping to get this in tomorrow
weskerfoot commented 5 years ago (Migrated from github.com)
Poster
Owner

This should be working now, but probably needs a bit more thought put into it. I'm not sure if the individual modules are the right place to put the attrs class definitions.

This should be working now, but probably needs a bit more thought put into it. I'm not sure if the individual modules are the right place to put the attrs class definitions.
weskerfoot commented 5 years ago (Migrated from github.com)
Poster
Owner

I've pretty high confidence that this is working now but I'm going to try and do a bit more refactoring and testing.

I've pretty high confidence that this is working now but I'm going to try and do a bit more refactoring and testing.
The pull request has been merged as beaa848a13.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.