Minor refactoring and reformatting #7

Merged
connorskees merged 1 commits from master into master 5 years ago
connorskees commented 5 years ago (Migrated from github.com)
Owner
  • Tighten whitespace
  • Remove superfluous assert statement
  • Reorder imports
  • Make parameters required and remove default values
- Tighten whitespace - Remove superfluous `assert` statement - Reorder imports - Make parameters required and remove default values
Nodraak commented 5 years ago (Migrated from github.com)
Owner

Thanks to if __name__ == "__main__":, the script can be run standalone, without pip install-ing it. Maybe you could should the README to let know people of this new feature?

Thanks to `if __name__ == "__main__":`, the script can be run standalone, without pip install-ing it. Maybe you could should the README to let know people of this new feature?
weskerfoot (Migrated from github.com) reviewed 5 years ago
weskerfoot (Migrated from github.com) commented 5 years ago
Owner

I'm assuming the disk-cache-size is necessary to persist sessions across runs? That's useful.

I'm assuming the `disk-cache-size` is necessary to persist sessions across runs? That's useful.
weskerfoot commented 5 years ago (Migrated from github.com)
Owner

Can you fix the conflicts? I think there are some useful things in here that weren't in your other PR

Can you fix the conflicts? I think there are some useful things in here that weren't in your other PR
connorskees commented 5 years ago (Migrated from github.com)
Poster
Owner

I fixed the conflicts and squashed the commits :-) I think it's good to go

I fixed the conflicts and squashed the commits :-) I think it's good to go
The pull request has been merged as 772066ef6d.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.