wes
/
DeleteFB
1
0
Fork 0
Code Issues 26 Pull Requests 3 Projects Releases 12 Wiki Activity
Labels Milestones

Add option for headless mode #10

Merged
connorskees merged 2 commits from feature-headless into master 6 years ago
Conversation 3 Commits 2 Files Changed 2
connorskees commented 6 years ago (Migrated from github.com)
Owner

Resolves https://github.com/weskerfoot/DeleteFB/issues/5 by adding the --headless, --disable-gpu, and log-level=2 flags which allow for Chromium to be run in headless mode.

Resolves https://github.com/weskerfoot/DeleteFB/issues/5 by adding the `--headless`, `--disable-gpu`, and `log-level=2` flags which allow for Chromium to be run in headless mode.
Nodraak commented 6 years ago (Migrated from github.com)
Owner

Why is --no-sandbox needed? It does not sound like something that I would like to use, from a security point of vue

Why is `--no-sandbox` needed? It does not sound like something that I would like to use, from a security point of vue
connorskees commented 6 years ago (Migrated from github.com)
Poster
Owner

@Nodraak You're right. I've removed the --no-sandbox flag :)

@Nodraak You're right. I've removed the `--no-sandbox` flag :)
weskerfoot commented 6 years ago (Migrated from github.com)
Owner

Looks great! Thanks for taking the time to clean things up as well.

Looks great! Thanks for taking the time to clean things up as well.
The pull request has been merged as daa5a32c92.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something isn't working dependencies
Pull requests that update a dependency file discussion documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested wontfix
This will not be worked on
No Label bug dependencies discussion documentation duplicate enhancement good first issue help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feature-headless'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes