rewrite of chromedriver download #114

Closed
whuji wants to merge 1 commits from download_last_chromedriver into master
whuji commented 4 years ago (Migrated from github.com)
Owner
  • Always pick the latest version of chromedriver
  • rewrited using requests instead of the old urllib package
- Always pick the latest version of chromedriver - rewrited using requests instead of the old urllib package
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

There's a specific way google recommends generating the chromedriver version

I'll have to look over this and see what can be merged from the stuff I was working on. My issue was that in order to find the best version of it, you have to know what version of chrome is installed, and that's tricky to do on windows.

There's a specific way google recommends generating the chromedriver version * First, construct a LATEST_RELEASE URL using Chrome's major version number. * For example, with Chrome version 73.0.3683.86, use URL https://chromedriver.storage.googleapis.com/LATEST_RELEASE_73". * Try to download a small file from this URL. If it successful, the file contains the ChromeDriver version to use. * If the above step failed, reduce the Chrome major version by 1 and try again. * For example, with Chrome version 75.0.3745.4, use URL "https://chromedriver.storage.googleapis.com/LATEST_RELEASE_74" I'll have to look over this and see what can be merged from the stuff I was working on. My issue was that in order to find the best version of it, you have to know what version of chrome is installed, and that's tricky to do on windows.
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

I think for now it might be fine to just use the latest on windows, and I can pull from this branch and integrate it into what I was doing maybe

I think for now it might be fine to just use the latest on windows, and I can pull from this branch and integrate it into what I was doing maybe
whuji commented 4 years ago (Migrated from github.com)
Poster
Owner

Maybe with wmic datafile get Version? Did you try? I can implement it if you want, but I must find a Windows to test it.

Maybe with wmic datafile get Version? Did you try? I can implement it if you want, but I must find a Windows to test it.
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

I can test it in a windows VM soon

I can test it in a windows VM soon
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

I've been fairly busy lately but I am going to try and do some work on this soon

I've been fairly busy lately but I am going to try and do some work on this soon
weskerfoot commented 4 years ago (Migrated from github.com)
Owner

I've got this working on my other branch. Closing this one.

I've got this working on my other branch. Closing this one.
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.