Update 2FA check to allow for other languages #26

Closed
jeanbaptistemora wants to merge 1 commits from patch-1 into master
jeanbaptistemora commented 6 years ago (Migrated from github.com)
Owner

Check for the specific string indicating 2FA step in several languages.

Added the string for french.

Tested by me on my french profile 👍

Thank you for your work 💯 💯 💯

Check for the specific string indicating 2FA step in several languages. Added the string for french. Tested by me on my french profile :+1: Thank you for your work :100: :100: :100:
weskerfoot commented 6 years ago (Migrated from github.com)
Owner

Thanks, I appreciate the contribution. I think that a more future proof approach would be to see if there is some kind of unique element attribute that we can use to detect the 2FA form, such that it would work for any language.

Looking at it in my browser, with 2FA enabled, there is always a form with the css class "checkpoint". Maybe something like this would work:

driver.find_element_by_xpath("//form[@class=\"checkpoint\"]")

I haven't tested it to see if it would work, but that might avoid the need to test multiple languages.

Thanks, I appreciate the contribution. I think that a more future proof approach would be to see if there is some kind of unique element attribute that we can use to detect the 2FA form, such that it would work for any language. Looking at it in my browser, with 2FA enabled, there is always a form with the css class `"checkpoint"`. Maybe something like this would work: ``` driver.find_element_by_xpath("//form[@class=\"checkpoint\"]") ``` I haven't tested it to see if it would work, but that might avoid the need to test multiple languages.
weskerfoot commented 6 years ago (Migrated from github.com)
Owner

I was able to add some checks that hopefully make it language agnostic in https://github.com/weskerfoot/DeleteFB/pull/31

@jeanbaptistemora would appreciate if you test it out

Closing this issue for now unless someone has any problems with 2FA in other languages.

I was able to add some checks that hopefully make it language agnostic in https://github.com/weskerfoot/DeleteFB/pull/31 @jeanbaptistemora would appreciate if you test it out Closing this issue for now unless someone has any problems with 2FA in other languages.
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.