Automatically download chrome driver. #92
driver_install into master 6 years ago
@ -0,0 +1,2 @@ |
|||
class UnknownOSException(Exception): |
|||
pass |
|||
@ -0,0 +1,117 @@ |
|||
|
|
|||
import re |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
import zipfile |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
import os, sys, stat, platform |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
from urllib.request import urlretrieve |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
from collections import namedtuple |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
from clint.textui import puts, colored |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
import progressbar |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
from selenium import webdriver |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
from .common import NO_CHROME_DRIVER |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
from ..exceptions import UnknownOSException |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
_ = namedtuple('WebDrivers', 'mac linux windows') |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
drivers = ['https://chromedriver.storage.googleapis.com/78.0.3904.70/chromedriver_mac64.zip', |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
'https://chromedriver.storage.googleapis.com/78.0.3904.70/chromedriver_linux64.zip', |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
'https://chromedriver.storage.googleapis.com/78.0.3904.70/chromedriver_win32.zip' |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
] |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
WebDriver = _(drivers[0], drivers[1], drivers[2]) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
def extract_zip(filename): |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
""" |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
Uses zipfile package to extract a single zipfile |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
:param filename: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
:return: new filename |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
""" |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
try: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
_file = zipfile.ZipFile(filename, 'r') |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
except FileNotFoundError: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
puts(colored.red(f"{filename} Does not exist")) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
sys.exit(1) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
# Save the name of the new file |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
new_file_name = _file.namelist()[0] |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
# Extract the file and make it executable |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
_file.extractall() |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
driver_stat = os.stat(new_file_name) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
os.chmod(new_file_name, driver_stat.st_mode | stat.S_IEXEC) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
_file.close() |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
os.remove(filename) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
return new_file_name |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
def setup_selenium(driver_path, options): |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
# Configures selenium to use a custom path |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
return webdriver.Chrome(executable_path=driver_path, options=options) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
def get_webdriver(): |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
""" |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
Ensure a webdriver is available |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
If Not, Download it. |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
""" |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
cwd = os.listdir(os.getcwd()) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
webdriver_regex = re.compile('chromedriver') |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
We could maybe also construct the expected filename (i.e.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
web_driver = list(filter(webdriver_regex.match, cwd)) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
if web_driver: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
# check if a extracted copy already exists |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
if not os.path.isfile('chromedriver'): |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
# Extract file |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
extract_zip(web_driver[0]) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
return "{0}/chromedriver".format(os.getcwd()) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
else: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
# Download it according to the current machine |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
os_platform = platform.system() |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
if os_platform == 'Darwin': |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
chrome_webdriver = WebDriver.mac |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
elif os_platform == 'Linux': |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
chrome_webdriver = WebDriver.linux |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
elif os_platform == 'Windows': |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
chrome_webdriver = WebDriver.windows |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
else: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
raise UnknownOSException("Unknown Operating system platform") |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
global total_size |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
def show_progress(*res): |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
global total_size |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
pbar = None |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
downloaded = 0 |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
block_num, block_size, total_size = res |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
if not pbar: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
pbar = progressbar.ProgressBar(maxval=total_size) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
pbar.start() |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
downloaded += block_num * block_size |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
if downloaded < total_size: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
pbar.update(downloaded) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
else: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
pbar.finish() |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
puts(colored.yellow("Downloading Chrome Webdriver")) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
file_name = chrome_webdriver.split('/')[-1] |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Review
I use
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
IMHO, I think this wouldn't be clearer since we will be making the person reading the code think that
Review
I totally agree with this. I would prefer
Review
Good point, I didn't realize at first that it was supposed to be a URL and not an actual path being split. A comment would help.
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
response = urlretrieve(chrome_webdriver, file_name, show_progress) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
if int(response[1].get('Content-Length')) == total_size: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
puts(colored.green(f"DONE!")) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
return "{0}/{1}".format(os.getcwd(), extract_zip(file_name)) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
|
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
else: |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
puts(colored.red("An error Occurred While trying to download the driver.")) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
# remove the downloaded file and exit |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
os.remove(file_name) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
sys.stderr.write(NO_CHROME_DRIVER) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
sys.exit(1) |
|||
|
Review
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Review
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Review
I'd prefer not shadowing the builtin
Review
I like to pass an exit code when calling
Review
just change this to be a single line
Review
I'd prefer something like
Review
maybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
Review
Might be good to create our own exception type here but I think it's fine as is
Review
Like I mentioned in my other comment I think using the
Review
Any Ideas on how we can do this?
Review
makes sense.
Review
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
Review
I totally agree with this. I would prefer
Review
I can handle it in a separate PR. I have some ideas for how to do it nicely. |
|||
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
I think we should have a way to dynamically get the latest chrome driver instead of statically hard-coding them.
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
Yeah, I was thinking that actually. It's not great to have to update the URL every time there's a new release.
I'd prefer not shadowing the builtin
file()constructorI'd prefer not shadowing the builtin
file()constructorI like to pass an exit code when calling
sys.exit(), so e.g.sys.exit(1)just to be more explicit about the error codesI like to pass an exit code when calling
sys.exit(), so e.g.sys.exit(1)just to be more explicit about the error codesjust change this to be a single line
return webdriver.Chrome(executable_path=driver_path, options=options)just change this to be a single line
return webdriver.Chrome(executable_path=driver_path, options=options)I'd prefer something like
return "{0}/chromedriver".format(os.getcwd())just for sylistic reasonsI'd prefer something like
return "{0}/chromedriver".format(os.getcwd())just for sylistic reasonsmaybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
webdrivers.darwinorwebdrivers.linux, etcmaybe webdrivers should be a namedtuple or something at the top level scope of the module? Then you could do
webdrivers.darwinorwebdrivers.linux, etcMight be good to create our own exception type here but I think it's fine as is
Might be good to create our own exception type here but I think it's fine as is
Like I mentioned in my other comment I think using the
.format()method of strings should be the way to do this (feel free to disagree, I just think it's a good convention to follow)Like I mentioned in my other comment I think using the
.format()method of strings should be the way to do this (feel free to disagree, I just think it's a good convention to follow)Any Ideas on how we can do this?
Any Ideas on how we can do this?
makes sense.
makes sense.
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
True. But I will go ahead and create our own Exception file just incase someone needs to add more exceptions in future.
I totally agree with this. I would prefer
fstrings but I am sure not everyone is using python>=3.6 🙂I totally agree with this. I would prefer
fstrings but I am sure not everyone is using python>=3.6 🙂I can handle it in a separate PR. I have some ideas for how to do it nicely.
I can handle it in a separate PR. I have some ideas for how to do it nicely.